Fix ptx symbol visibility regression #1609
Merged
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM 14 introduced two ptx regressions to our file-scoped static variables:
This lead to duplicate symbol errors when building an OptiX pipeline with multiple shaders.
We attempted a fix using anonymous namespaces in #1561, but kept the static keyword, resulting in a partial solution.
Removing static generates ptx that matches LLVM 12 for the affected variable definitions.
Here's a section of
group_0.ptx
fromtestoptix-noise
, before and after:Also included: Fix a clang warning that was breaking my
-Werror
build, although I'm confused why CI didn't catch it previously.