Deal with deprecated bit_cast function in OIIO 2.5 #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today's branching of OIIO 2.4 and subsequent changing of its master branch to think it's "2.5" seems to have triggered an automatic fuse that annotates a particular function in OIIO as deprecated for version 2.5 and beyond. OSL was still calling the old version, so some immediate changes are necessary to call the correct new name when using a new OIIO. Signed-off-by: Larry Gritz <[email protected]>
fpsunflower
approved these changes
Sep 1, 2022
|
Oh nevermind - I dug up the OIIO PR, I forgot about the argument ordering difference 😅 |
|
Yeah, seemed like having the identically named function with opposite template argument order was bound to be trouble, so I'm trying to deprecate and phase ours out before anybody is using C++20 too widely. |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Sep 1, 2022
…undation#1569) Today's branching of OIIO 2.4 and subsequent changing of its master branch to think it's "2.5" seems to have triggered an automatic fuse that annotates a particular function in OIIO as deprecated for version 2.5 and beyond. OSL was still calling the old version, so some immediate changes are necessary to call the correct new name when using a new OIIO. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Sep 1, 2022
…undation#1569) Today's branching of OIIO 2.4 and subsequent changing of its master branch to think it's "2.5" seems to have triggered an automatic fuse that annotates a particular function in OIIO as deprecated for version 2.5 and beyond. OSL was still calling the old version, so some immediate changes are necessary to call the correct new name when using a new OIIO. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today's branching of OIIO 2.4 and subsequent changing of its master
branch to think it's "2.5" seems to have triggered an automatic fuse
that annotates a particular function in OIIO as deprecated for version
2.5 and beyond. OSL was still calling the old version, so some
immediate changes are necessary to call the correct new name when
using a new OIIO.
Signed-off-by: Larry Gritz [email protected]