More comprehensive warnings about things that don't optimize away #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpsunflower
approved these changes
May 1, 2022
AlexMWells
reviewed
May 2, 2022
| /// int opt_warnings Warn on failure to runtime-optimize certain | ||
| /// shader constructs. (0) | ||
| /// int gpu_opt_error Issue a hard error if certain shader | ||
| /// constructs cannot be optimized away, which |
There was a problem hiding this comment.
Can we turn on gpu_opt_error even if we are running on the cpu? (In order to get a shader into shape before trying the GPU)
There was a problem hiding this comment.
That is 100% the point, yes.
New classes of warnings triggered when enabling option "opt_warnings": * Creation of new strings mid-shader. * Access to the characters of strings mid-shader. We already warned about texture access by name that could not be turned into a handle. In all of these cases, we only warn *after* runtime optimization, so that shader idioms in the source code that appear to do these forbidden things will not warn as long as they can be reduced to safe operations in the course of the runtime optimization step. Signed-off-by: Larry Gritz <[email protected]>
|
@lkerley FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New classes of warnings triggered when enabling option "opt_warnings":
We already warned about texture access by name that could not be
turned into a handle.
In all of these cases, we only warn after runtime optimization, so that shader
idioms in the source code that appear to do these forbidden things will not warn
as long as they can be reduced to safe operations in the course of the runtime
optimization step.
Signed-off-by: Larry Gritz [email protected]