Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACES2065-1 and ACEScg as shading system color spaces #1486

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

brechtvl
Copy link
Contributor

Description

Make functions like blackbody and wavelength work with ACES color spaces.

Another approach would be to get this information from OpenColorIO configs that have an aces_interchange and rendering role, but that's more complicated and does not work for all configs. This just adds two entries to the existing list.

Tests

New test added for shading system colorspace attribute.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@AlexMWells
Copy link
Contributor

Nice remembering to add the BATCHED to the colorspace unit test!

To make functions like blackbody, wavelength and luminance work with these
color spaces.

Signed-off-by: Brecht Van Lommel <[email protected]>
@lgritz lgritz merged commit 8791352 into AcademySoftwareFoundation:main Apr 15, 2022
@lgritz
Copy link
Collaborator

lgritz commented Apr 15, 2022

Thanks, @brechtvl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants