Pr/batched dict #1445
Merged
Pr/batched dict #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered mismatch between documentation, llvm_gen implementation, and oslc when passing user derivatives to texture3d. oslc and documentation expect optional parameters "vector dpdx, vector dpdy, vector dpdz", however llvm_gen and optexture implementation only accept "vector dpdx, vector dpdy" and use 0 for dpdz when calling into the texture subsystem. This commit includes changes to oslc to make the compiler match the implementation of accepting only "vector dpdx, vector dpdy". Enable BATCHED execution of testsuite/texture3d Add new regression test textur3d-opts-reg Signed-off-by: Alex M. Wells <[email protected]>
… only user inputs that include dpdz: "vector dpdx, vector dpdy, vector dpdz". Fixed llvm_gen and optexture to properly extract user dpdz from texture3d options or initialize a Vec3(0) and pass through to texture subsystem. Modified batched_llvm_gen and wide_optexture to properly extract user dpdz from texture3d options or initialize a Wide<Vec3>(0) and pass through to texture subsystem. Updated texture3d-opts-reg test to pass dpdz for calls taking user derivatives. Signed-off-by: Alex M. Wells <[email protected]>
Added BatchedRendererServices::environment virtual method Added new test environment Added new regression test environment-opt-reg Signed-off-by: Alex M. Wells <[email protected]>
…t-opts-reg to line up with a different PR adding testsuite/texture-environment. Signed-off-by: Alex M. Wells <[email protected]>
Enabled BATCHED execution of texture-environment Signed-off-by: Alex M. Wells <[email protected]>
Implementation takes advantage of uniform values and only does lookup once and broadcasts results if necessary. When nodeid is varying, it falls back to simple loop over active data lanes performing lookups. Signed-off-by: Alex M. Wells <[email protected]>
Enabled BATCHED execution of existing xml test Signed-off-by: Alex M. Wells <[email protected]>
Signed-off-by: Alex M. Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add batched support for dict find, dict next, dict value.
Implementation takes advantage of uniform values and only does lookup once and broadcasts results if necessary.
When nodeid is varying, it falls back to simple loop over active data lanes performing lookups.
Tests
Added new regression test xml-reg.
Enabled BATCHED execution of existing xml test
Checklist: