Fix compatibility with LLVM 12 and up #1412
Conversation
|
Can you please amend your commit with the Signed-off-by field to complete the DCO, and then push --force? Thanks. |
Upstream LLVM stopped using the compatibility
spellings of OF_{None,Text,Append} from version 12 and up.
https://reviews.llvm.org/D101650
Signed-off-by: Luya Tshimbalanga <[email protected]>
luyatshimbalanga
force-pushed
the
master
branch
from
dc11f3f to
b577110
Compare
|
|
Done. It is the first time I noticed the EasyCLA, I don't know if either I or you need to fill the authorization. |
|
The CLA is for you to sign (or your employers, if you work someplace that owns your IP output). |
|
You only have to do the CLA signing once; it will apply to all future PRs to this project from the same github account. |
Done |
| @@ -1407,7 +1407,9 @@ LLVM_Util::make_jit_execengine (std::string *err, | |||
|
|
|||
| options.NoZerosInBSS = false; | |||
| options.GuaranteedTailCallOpt = false; | |||
| #if OSL_LLVM_VERSION < 120 | |||
There was a problem hiding this comment.
A lot of us had already been building against LLVM 12 with no problem.
Is this maybe supposed to be "130", meaning, it was present in LLVM <= 12 but is missing from >= 13?
There was a problem hiding this comment.
The build failed on Fedora 34 which comes with LLVM 12 hence the condition. It is possible the bug only affected that distribution but I can modify the pull merge.
There was a problem hiding this comment.
No, it's fine. I was just trying to understand what was going on.
There was a problem hiding this comment.
LGTM, as far as the code itself, I am ready to merge it, pending an answer about the question about LLVM 12.
I'm confused about whether this is really fixing compatibility with "LLVM 12 and up" or if it's "LLVM 13 and up." If it's 12, why was everybody else able to build against 12 without any trouble?
Upstream LLVM stopped using the compatibility
spellings of OF_{None,Text,Append} from version 12 and up.
https://reviews.llvm.org/D101650
Signed-off-by: Luya Tshimbalanga <[email protected]>
Description
This pull request addresses a compatibility with LLVM 12 due to the change within LLVM itself. Additionally, this also fix the merge from release to master on #1402
Tests
N/A See https://reviews.llvm.org/D101650
Checklist: