OSLCompiler : Check for write errors #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AcademySoftwareFoundation#1352 Signed-off-by: John Haddon <[email protected]>
|
|
lgritz
approved these changes
Apr 19, 2021
|
Not sure what went wrong with the CLA the first time - it had been signed and I'd even received confirmation emails that I'd been added to the approved list. We started again from scratch with a new organisation and it appears to have worked this time. |
lgritz
approved these changes
Apr 20, 2021
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 22, 2021
Fixes AcademySoftwareFoundation#1352 Signed-off-by: John Haddon <[email protected]>
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this pull request
Nov 22, 2021
Despite AcademySoftwareFoundation/OpenShadingLanguage#1360, we have still seen one example of an empty `.oso` file being produced in production. Adding further checks will hopefully help us get to the bottom of it if it happens again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1352 by checking for write errors after writing the
.osofile. Without it, empty files could be written without error after running out of disk space.Tests
I have not added any new tests, although in #1352 I did provide an example script to demonstrate the problem. I've been unable to find a way of simulating an empty disk without requiring root privilege, which I presume makes it unsuitable as a test.
Checklist: