CMake 3.20 safety #1354
Merged
CMake 3.20 safety #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that our liberal use of cmake argument `--config` should only be used in conjunction with the `--build` flag, not for the initial configuration step. Apparently this was just silently ignored for a long time, but for CMake 3.20, it is an error and breaks a lot of our CI cases and our build_blah.bash scripts. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 2, 2021
It seems that our liberal use of cmake argument `--config` should only be used in conjunction with the `--build` flag, not for the initial configuration step. Apparently this was just silently ignored for a long time, but for CMake 3.20, it is an error and breaks a lot of our CI cases and our build_blah.bash scripts. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 2, 2021
It seems that our liberal use of cmake argument `--config` should only be used in conjunction with the `--build` flag, not for the initial configuration step. Apparently this was just silently ignored for a long time, but for CMake 3.20, it is an error and breaks a lot of our CI cases and our build_blah.bash scripts. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that our liberal use of cmake argument
--configshould onlybe used in conjunction with the
--buildflag, not for the initialconfiguration step. Apparently this was just silently ignored for a
long time, but for CMake 3.20, it is an error and breaks a lot of our
CI cases and our build_blah.bash scripts.
A couple of other minor cosmetic fixes in those scripts as well.
Signed-off-by: Larry Gritz [email protected]