Add ShadingSystem attribute "searchpath:library" (similar to searchpa… #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th:shader) that is used to identify directories where target ISA optimized OSL shared libraries may exit
Remove testshade command line parameters of "path" and "librarypath" as they were never used and can still be specified with "options". Remove get_executable_directory() function and use OIIO::Filesystem::parent_path(OIIO::Sysutil::this_program_path()) Change additional relative directory to search for libraries from "/../liboslexec" to "/../lib". Fix processing of relative directories to be a loop to correctly prefix executable's path.
lgritz
requested changes
Dec 5, 2020
AlexMWells
commented
Dec 7, 2020
|
Changes have been pushed, CI has passed(expect appveyor), so ready for review/approve/merge. |
lgritz
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(similar to searchpath:shader) it will be used to identify directories where target ISA optimized OSL shared libraries may exit.
Make testshade set "searchpath:library" to ../lib64 and ../liboslexec relative to the path testshade is executed from
Description
Tests
Checklist: