Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate cudaMalloc symbol error when compiling with CUDA9+ #1271

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix duplicate cudaMalloc symbol error when compiling with CUDA9+ #1271

merged 1 commit into from
Oct 16, 2020

Conversation

DeclanRussell
Copy link
Contributor

Description

Something changed in the CUDA headers between 8 and 9 and you now need the __CUDADEVRT_INTERNAL__ define when compiling the gpu bitcode to avoid duplicate cudaMalloc symbol errors.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@DeclanRussell
Add __CUDADEVRT_INTERNAL__ define to bitcode generation, needed to av…
28e9faf 
…oid duplicate cudaMalloc symbols with CUDA9+
@lgritz lgritz merged commit 00e56af into AcademySoftwareFoundation:master Oct 16, 2020
@DeclanRussell DeclanRussell deleted the OptiXBuild branch October 17, 2020 11:42
lgritz pushed a commit to lgritz/OpenShadingLanguage that referenced this pull request Oct 20, 2020
@DeclanRussell @lgritz
Add __CUDADEVRT_INTERNAL__ define to bitcode generation, needed to av…
c79f667 
…oid duplicate cudaMalloc symbols with CUDA9+ (AcademySoftwareFoundation#1271)

Co-authored-by: Declan Russell <[email protected]>
lgritz pushed a commit to lgritz/OpenShadingLanguage that referenced this pull request Oct 20, 2020
@DeclanRussell @lgritz
Add __CUDADEVRT_INTERNAL__ define to bitcode generation, needed to av…
72af172 
…oid duplicate cudaMalloc symbols with CUDA9+ (AcademySoftwareFoundation#1271)

Co-authored-by: Declan Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeclanRussell @lgritz