Explicitly set the OptiX pipeline stack size. #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried out this patch locally and it fixes the issues I was seeing with recent drivers. LGTM! |
lgritz
reviewed
Sep 23, 2020
| @@ -527,20 +529,18 @@ OptixRaytracer::make_optix_materials () | |||
| size_t sizeof_msg_log; | |||
|
|
|||
| // Make module that contains programs we'll use in this scene | |||
| OptixModuleCompileOptions module_compile_options; | |||
| OptixModuleCompileOptions module_compile_options = {}; | |||
There was a problem hiding this comment.
Can I ask... what is going on with this line?
There was a problem hiding this comment.
Just making sure the options are zero-initialized.
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Sep 23, 2020
…ion#1254) Co-authored-by: Tim Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testrenderandtestshadewere both relying on the automatic pipeline stack size computation in OptiX 7. This was causing a handful of tests to fail for reasons that are still not clear. Computing and manually setting the required stack size clears up the failures.Tests
I didn't add any tests, but all existing tests pass with this change.
Checklist: