Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer diagram improvements #189

Merged
merged 18 commits into from
May 14, 2024
Merged

Layer diagram improvements #189

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
face56c
Add suggested physically-based approximate formula for coat roughening.
portsmouth Apr 15, 2024
b5e7af8
Merge branch 'main' into coat_roughening
jstone-lucasfilm Apr 16, 2024
6c66e3b
Take into account TT mode in coat roughening formula.
portsmouth Apr 28, 2024
c5b4a1b
Merge branch 'main' into coat_roughening
portsmouth Apr 29, 2024
3b0fd12
Merge branch 'main' into coat_roughening
portsmouth Apr 30, 2024
1edaca3
Merge branch 'main' into coat_roughening
portsmouth Apr 30, 2024
5569167
Merge branch 'main' into coat_roughening
portsmouth May 10, 2024
d7de8b4
Remove approx. roughening formula.
portsmouth May 10, 2024
7529555
Merge remote-tracking branch 'upstream/main' into coat_roughening
portsmouth May 10, 2024
5eb4dbb
Add MaterialX implementation of the more realistic coat roughening fo…
portsmouth May 10, 2024
930ce21
Merge branch 'coat_roughening' of https://github.com/portsmouth/OpenP…
portsmouth May 10, 2024
54b5ec8
Fix mix node
portsmouth May 10, 2024
9c018c1
Merge remote-tracking branch 'upstream/main' into coat_roughening
portsmouth May 11, 2024
5a12a38
Improve wording.
portsmouth May 11, 2024
d56c85b
Improvements to layer tree diagram
portsmouth May 11, 2024
69e25b9
Merge remote-tracking branch 'upstream/main' into layer_graph_improve
portsmouth May 13, 2024
21cf8ca
Merge remote-tracking branch 'upstream/main' into layer_graph_improve
portsmouth May 14, 2024
1b69442
Remove duplicated section
portsmouth May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified images/layer_graph.png
View file
Open in desktop
Copy link
Contributor

@virtualzavie virtualzavie May 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this node diagram is now closer to the layering diagram (illustration in the PR description), it makes me realise we might have an inconsistency.

From this tree structure, I understand the dielectric specular lobe, represented by the "gloss" node, will only apply to the diffuse layer. If the translucent or subsurface weight is 1, both the diffuse lobe and its glossy lobe are nulled.

This seems in conflict with the descriptions of the dielectric layers, from which I understand all 3 dielectric cases share the same specular lobe.
Quoting the outline:

The interface (dielectric or metal) of this base layer produces the primary specular reflection lobe. The dielectric base represents either of three components, that can be statistically mixed:

I understand that to represent this we can choose from either:

  • one single gloss layer on top of all the dielectric components (translucent, subsurface and diffuse).
  • a separate gloss layer on top of each of the dielectric components.
  • omit the gloss layer from the diagram, and consider that each of the component produce their own specular lobe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading the spec, I see the diffuse slab is specified differently from the translucent and subsurface one, where the diffuse slab only has a diffuse BRDF, whereas the other two have a dielectric specular BRDF and a volume.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading