Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ocio_depts handling spaces in file paths #2109

Merged

Conversation

DevTGHa
Copy link
Contributor

@DevTGHa DevTGHa commented Dec 17, 2024

share/dev/windows/ocio_deps.bat was not able to find the installed visual studio location due to the space in the paths. This is because for /f splits on spaces and tabs by default.

For example, C:\Program Files (x86) becomes C:\Program.

Adding delims= to avoid splitting the output of the command and keeps the entire path in %%i.

Copy link

linux-foundation-easycla bot commented Dec 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@doug-walker doug-walker requested a review from cozdas January 6, 2025 18:13
Copy link
Collaborator

@cozdas cozdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this.

@doug-walker doug-walker merged commit c5c85b0 into AcademySoftwareFoundation:main Jan 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants