-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Workflows various fixes #1945
CI Workflows various fixes #1945
Conversation
9790c5a
to
071ee0e
Compare
6fbe6e5
to
3c6a5fe
Compare
d4fe879
to
ee1c548
Compare
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
ee1c548
to
39e8212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
My only comment is whether we should include the GIL release in this PR? https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1945/files#diff-6c87f76bfb1f06a48bb762f97632eee604f4d8cd2e852347c3b46209a056086a Those seems to be beyond pure CI workflow changes. If people are happy with it then fine. |
@KelSolaar, given the large delays in getting PRs merged, we all sometimes include small miscellaneous improvements into a larger PR. It's not ideal, but it's a response to the current state of affairs where we don't have a sufficient number of reviewers. |
@doug-walker : All good with me and I understand the frustration! It is one of the reason I have been hesitant to move |
9fe81cb
into
AcademySoftwareFoundation:main
Merging for good measure because the aforementioned note was the only comment I had! Thanks @remia. |
Such rules are made by every project TSC individually to pick the right set of procedures for their project and team. There is no ASWF-mandated policy on how reviews and merges work. |
I'm sorry, I see I was tagged here, but I didn't notice this PR until today. Apologies if you wanted me to look at something here and I failed to reply. (I do "watch" this project, but sometimes when I'm busy, I'm a little eager with the delete key if I don't see a PR title that I think is highly relevant to me.) |
@KelSolaar Agree the GIL changes could have been separated in a different PR, I included these here because it fixed the WIndows Platform Latest workflow when I switched them to C++23. @lgritz No worry at all! I tagged you because I made some OSL related fix for the unit tests. |
This PR attempt to fix various issues on the GHA workflows:
Update the CI on Linux to add VFX 2024 Reference Platform new containers (thanks @jfpanisset), there is currently an issue with OIIO's Ptex dependency which might need a fix in the OCIO Docker image.Revert this change, will wait for the next ASWF Docker release.