-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderable logic improvements to web viewer #1644
Merged
jstone-lucasfilm
merged 13 commits into
AcademySoftwareFoundation:main
from
kwokcb:webviewer_renderables
Jan 10, 2024
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3734df3
Additional scanning logic, firewall checks, and api call fixes.
kwokcb 3ef13b4
- Color renderable folders based on if assigned or not.
kwokcb 1a78783
Check in coloring for material folders.
kwokcb 8b0dd7d
Merge remote-tracking branch 'aswf/main' into webviewer_renderables
kwokcb ed5da20
Rev 1 of adding material assignment UI.
kwokcb dee11e1
Add in soloing logic.
kwokcb 8378bc4
Add in shaderball icon.
kwokcb dfdafc5
Merge remote-tracking branch 'aswf/main' into webviewer_renderables
kwokcb 7bcaef4
Cleanup.
kwokcb 276b486
Update shaderball icon.
kwokcb a1186f8
Side-step performance cliff when setting programs on geometry.
kwokcb 8d79369
Update comments on shader debug flag.
kwokcb f610944
Whitespace fix
jstone-lucasfilm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one cause of extreme slowdown for loading in scenes with a number of standard surface shaders. It is slower for this than say UsdPreviewSurface since there are more uniforms to inspect for debugging. Each causes a pipeline stall. Once removed then the remaining profile time found was for texture load (if any) but this is an incremental load.