Fix python imath export #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes thread library search, which is unused here. Signed-off-by: Kimball Thurston <[email protected]>
meshula
approved these changes
Sep 5, 2021
sthagen
added a commit
to sthagen/AcademySoftwareFoundation-Imath
that referenced
this pull request
Sep 9, 2021
Fix python imath export (AcademySoftwareFoundation#207)
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 17, 2022
Also removes thread library search, which is unused here. Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Jan 20, 2022
Also removes thread library search, which is unused here. Signed-off-by: Kimball Thurston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes thread library search, which is unused in this project.
the python support was exporting a custom library config (fine, although of dubious value, seems like that could just be simplified and merged to imath), but was not starting a new project definition, so was inheriting the same name, causing a duplicate export. It should be noted that this changes the requirements for making a release, where the version number needs to be updated in two places now to keep imath and pyimath in sync.
Signed-off-by: Kimball Thurston [email protected]