Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audiolink laser handling in VRSL_ManagerWindow.cs #38

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mrTomatolegit
Copy link
Contributor

@mrTomatolegit mrTomatolegit commented Oct 18, 2024

Fixes #39
If there is an audiolink laser in the scene and the user either:

  • Tries to Update Fixtures in the VRSL Control Panel
  • Tries to open an audiolink band in the UI

The console will print and error or spam errors respectively.

This change prevents the errors without change in functionality.

For more images, check my Discord Messages here (VRSL/Club Orion): https://discordapp.com/channels/855872620917293066/855876755633471529/1296624717783896106

If there is an audiolink laser in the scene and the user either:
- Tries to `Update Fixtures` in the VRSL
- Tries to open an audiolink band
The console will print and error or spam errors respectively.

This change prevents the errors without functionality.
@mrTomatolegit
Copy link
Contributor Author

mrTomatolegit commented Oct 21, 2024

Been using this branch for 3 days, no issues to report here!

@vesturo
Copy link

vesturo commented Oct 21, 2024

@AcChosen can confirm this fixes the issue, mind merging it in / implementing the fix?

Copy link
Owner

@AcChosen AcChosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the hotfix!

@AcChosen AcChosen merged commit 7344ae8 into AcChosen:main Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lasers in Audiolink break "Update Fixtures"
3 participants