Update dependencies #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates versions of bindgen and parking_lot to newer version. Bingen update is crucial as in PR#2284 they have updated crate structure to remove a lot of unused dependencies.
I also remove the the patch version from the crates.
The reason it is better not to keep patch versions is that tracing-oslog is a library create. It would be always a dependency of some other (let's call it main) crate. If this main crate depends on, say, on
tracing-core = "0.1.20", then havingtracing-core = "0.1.21"in this crate might create a problem. Assuming all dependencies follow semver,tracing-oslogshould work fine with any patch versionSee more here and here
P.S. Any plans to make tracing-oslog v0.2.0 soon?