Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: enabled/disabled state #55

Merged

Conversation

KabaDH
Copy link
Contributor

@KabaDH KabaDH commented Jan 24, 2024

This PR is a preview and is not yet ready for production.

This PR introduces a new parameter "enabled" for all CustomDropdown constructors. Setting this parameter to "false" you set the "disabled" state. In the disabled state you can not open the dropdown. Disabled state has its own decoration (disabledDecoration). Disabled state is safe to use with empty input options data.

As a minor feature, this PR introduces parameter "closeDropDownOnClearFilterSearch". Setting this parameter to "true" will cause to close the dropdown upon clicking "Clear filter" cross in any CustomDropdown constructor with search filter.

  • Added new fields and adapted existing constructors
  • Updated builders to handle "enabled" state
  • Performed some tests.

@KabaDH KabaDH mentioned this pull request Jan 24, 2024
@AbdullahChauhan
Copy link
Owner

Hey @KabaDH Thanks much for the contribution. 😊
I'm start reviewing this. Will merge soon if all good!

@AbdullahChauhan AbdullahChauhan merged commit 7868d08 into AbdullahChauhan:master Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants