Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disks stats for windows #57

Merged
merged 9 commits into from
Nov 9, 2024

Conversation

NoPlagiarism
Copy link
Contributor

Description

Disables disk filtering for Windows

Mentioned in #40

Type of change

Bug fix

Tests

  • Before merging test it on Linux

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

@Abdenasser
Copy link
Owner

@NoPlagiarism can you fix the build issues, looks like those are private fields.

@NoPlagiarism
Copy link
Contributor Author

Sorry for that

@Abdenasser
Copy link
Owner

Sorry for that

no worries, thank you!

@Abdenasser
Copy link
Owner

@NoPlagiarism would you like to address the following

error[E0308]: mismatched types
  --> src/main.rs:83:5
   |
82 |   fn filter_disks(disks: &[Disk]) -> Iter<Disk> {
   |                                      ---------- expected `std::slice::Iter<'_, sysinfo::Disk>` because of return type
83 | /     disks.iter().filter(|disk| {
84 | |         // Filter for physical disks - typically those mounted at "/"
85 | |         disk.mount_point() == std::path::Path::new("/")
86 | |     })
   | |______^ expected `Iter<'_, Disk>`, found `Filter<Iter<'_, Disk>, ...>`
   |
   = note: expected struct `std::slice::Iter<'_, _>`
              found struct `Filter<std::slice::Iter<'_, _>, {closure@src/main.rs:83:25: 83:31}>`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `macos-task-manager` (bin "macos-task-manager") due to 1 previous error
failed to build app: failed to build app
    Error failed to build app: failed to build app
Error: Process completed with exit code 1.

@Abdenasser Abdenasser mentioned this pull request Nov 9, 2024
9 tasks
Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@Abdenasser Abdenasser merged commit adb99e9 into Abdenasser:main Nov 9, 2024
1 check passed
@NoPlagiarism
Copy link
Contributor Author

Thanks for fixing it

@NoPlagiarism NoPlagiarism deleted the fix/windows_disks branch November 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants