Migrate to tauri v2 #18
Conversation
src-tauri/src/main.rs
Outdated
| @@ -1,20 +1,12 @@ | |||
| #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] | |||
|
|
|||
| use std::collections::HashMap; | |||
There was a problem hiding this comment.
what formatter are we using? this would be hard for me to carefully review, can we only change code related to migration and keep the same formatting as before?
There was a problem hiding this comment.
otherwise everything else looks good to me, thank you 👍🏻
There was a problem hiding this comment.
It has been formatted using the default rust lang support plugin for vscode.
I have reverted my changes, please take a look at it again
src-tauri/Cargo.toml
Outdated
| tauri-plugin-process = "2" | ||
| tauri-plugin-fs = "2" | ||
| tauri-plugin-dialog = "2" | ||
| tauri-plugin-clipboard-manager = "2.0.2" |
There was a problem hiding this comment.
@Pinguin2001 are these some V2 requirements ?
tauri-plugin-os = "2"
tauri-plugin-http = "2"
tauri-plugin-notification = "2"
tauri-plugin-process = "2"
tauri-plugin-clipboard-manager = "2.0.2"
tauri-plugin-global-shortcut = "2"
src-tauri/Cargo.toml
Outdated
| @@ -25,3 +33,6 @@ lto = "fat" # More aggressive link-time optimization | |||
| opt-level = 3 # Optimize for maximum performance | |||
| strip = true # Remove debug symbols | |||
| incremental = false # Disable incremental compilation | |||
|
|
|||
| [target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dependencies] | |||
| tauri-plugin-global-shortcut = "2" | |||
src-tauri/capabilities/desktop.json
Outdated
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "identifier": "desktop-capability", | |||
There was a problem hiding this comment.
why we need this one? while we don't expose any command called desktop-capability.
src-tauri/capabilities/migrated.json
Outdated
| @@ -0,0 +1,87 @@ | |||
| { | |||
| "identifier": "migrated", | |||
There was a problem hiding this comment.
is there a command called migrated??
There was a problem hiding this comment.
Capabilities are a new feature that granularly enables and constrains the core exposure to the application front-end. They are essentially a set of permissions mapped to application windows. The migrated.js represents the list of capabilities, extracted during the automatic migration step, used in the app.
There was a problem hiding this comment.
yeah they are new, but not just random.. the identifiers would most of the time refer to commands we expose in invoke handler.. I remember using the windows identifier as "windows"
There was a problem hiding this comment.
not because it was added by the migration script that this is the way it should be.. try creating an app with V2 directly.
src-tauri/src/main.rs
Outdated
| .plugin(tauri_plugin_notification::init()) | ||
| .plugin(tauri_plugin_http::init()) | ||
| .plugin(tauri_plugin_shell::init()) | ||
| .plugin(tauri_plugin_os::init()) |
There was a problem hiding this comment.
why adding this full list of plugins?
There was a problem hiding this comment.
In Tauri 1.0, many plugins were included by default potentially including unnecessary functionality. With Tauri 2.0, the framework has moved towards a more modular approach, where you explicitly add only the plugins you need.
There was a problem hiding this comment.
interesting, but still I'm not 100% sure they are required.. worth exploring a bit more
There was a problem hiding this comment.
I agree. The new version of Tauri brings a lot to the table
There was a problem hiding this comment.
interesting, but still I'm not 100% sure they are required.. worth exploring a bit more
Not all of them are required, I'm exploring and testing right now.
|
These changes were automatically added by the tauri v2 migrator. Changes have been reverted as requested, in case you need a plugin from tauri later, it has to be added manually. |
|
@Abdenasser Please take a look at it again, I have tested all functionality and everything seems to be working correctly. |
great job @Pinguin2001 |
This commit migrates the project to the latest tauri v2.
As I currently do not have access to a device running a relatively new version of mac os currently, functionality on macOS should be validated first before merging this pr