Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-essential package #522

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add build-essential package #522

merged 1 commit into from
Jun 26, 2023

Conversation

KagurazakaNyaa
Copy link
Contributor

Fix the problem that some extensions need to be installed from src
Now, because the step of installing extensions is moved forward in entrypoint.sh instead of startup.sh, we cannot install some required packages before executing install.py
When installing the extension sd-webui-roop, it relies on insightface==0.7.3, and when installing this pypi package, it is found that when building the wheel package, an error will be reported because gcc cannot be found
https://github.com/s0md3v/sd-webui-roop/blob/ddc02ee1a914ba387fa338f9542ec16d128c56e5/requirements.txt#L1
Therefore, considering that not all pypi packages are distributed in wheel, those pypi packages distributed in src need build-essential to build

Fix the problem that some extensions need to be installed from src
Copy link
Owner

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Maybe we should change the order of installation....

@AbdBarho AbdBarho merged commit 37a82af into AbdBarho:master Jun 26, 2023
@KagurazakaNyaa KagurazakaNyaa deleted the patch-1 branch June 27, 2023 00:09
sf666 added a commit to sf666/sd that referenced this pull request Jul 3, 2023
* Abd_master:
  Auto 1.4.0 (AbdBarho#507)
  Bump auto
  Add build-essential package (AbdBarho#522)
  Allow setting port through env WEBUI_PORT (AbdBarho#521)
  Create dirs if not exist (AbdBarho#520)
  Modify installation extension dependencies (AbdBarho#518)
  v8 (AbdBarho#516)

# Conflicts:
#	data/.gitignore
#	docker-compose.yml
cloudaxes pushed a commit to cloudaxes/stable-diffusion-webui-docker that referenced this pull request Sep 6, 2023
Fix the problem that some extensions need to be installed from src
Now, because the step of installing extensions is moved forward in
`entrypoint.sh` instead of `startup.sh`, we cannot install some required
packages before executing `install.py`
When installing the extension `sd-webui-roop`, it relies on
`insightface==0.7.3`, and when installing this pypi package, it is found
that when building the wheel package, an error will be reported because
`gcc` cannot be found

https://github.com/s0md3v/sd-webui-roop/blob/ddc02ee1a914ba387fa338f9542ec16d128c56e5/requirements.txt#L1
Therefore, considering that not all pypi packages are distributed in
wheel, those pypi packages distributed in src need `build-essential` to
build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants