fix printing bug #57
fix printing bug #57
Conversation
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request addresses a printing bug in the is_git_repo method of the LocalIO class. The change to use capture_output=True in the subprocess.run call is appropriate and should resolve the issue. The version bump in pyproject.toml is consistent with this being a bug fix. Overall, this is a small but important improvement to the project.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
| @@ -7,7 +7,7 @@ packages=["ragdaemon"] | |||
|
|
|||
| [project] | |||
| name = "ragdaemon" | |||
| version = "0.8.1" | |||
| version = "0.8.2" | |||
There was a problem hiding this comment.
The version bump from 0.8.1 to 0.8.2 is appropriate for a bug fix. Make sure this change is documented in the project's changelog if one exists.
| @@ -51,7 +51,7 @@ def is_git_repo(self, path: Optional[Path | str] = None): | |||
| if path: | |||
| args.append(Path(path).as_posix()) | |||
| try: | |||
| output = subprocess.run(args, cwd=self.cwd) | |||
| output = subprocess.run(args, cwd=self.cwd, capture_output=True) | |||
There was a problem hiding this comment.
| output = subprocess.run(args, cwd=self.cwd, capture_output=True) | |
| output = subprocess.run(args, cwd=self.cwd, capture_output=True) |
Good catch. This change prevents the subprocess output from being printed to the console, which is likely the intended behavior for this method. It's a proper fix for the printing bug mentioned in the PR summary.
No description provided.