davidjbradshaw#423 Properly removes event listeners.

Aaronius · Nov 3, 2016 · 075e3ac · 075e3ac
1 parent fd46591
commit 075e3ac
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 16 deletions.
diff --git a/js/ie8.polyfils.map b/js/ie8.polyfils.map
diff --git a/js/ie8.polyfils.min.js b/js/ie8.polyfils.min.js
diff --git a/js/iframeResizer.contentWindow.js b/js/iframeResizer.contentWindow.js
@@ -63,7 +63,8 @@
 				warn('Custom width calculation function not defined');
 				return document.body.scrollWidth;
 			}
-		};
+		},
+		eventHandlersByName   = {};
 
 
 	function addEventListener(el,evt,func){
@@ -265,15 +266,21 @@
 
 
 	function manageTriggerEvent(options){
-		function handleEvent(){
-			sendSize(options.eventName,options.eventType);
-		}
 
 		var listener = {
 			add:    function(eventName){
+				function handleEvent(){
+					sendSize(options.eventName,options.eventType);
+				}
+
+				eventHandlersByName[eventName] = handleEvent;
+
 				addEventListener(window,eventName,handleEvent);
 			},
 			remove: function(eventName){
+				var handleEvent = eventHandlersByName[eventName];
+				delete eventHandlersByName[eventName];
+
 				removeEventListener(window,eventName,handleEvent);
 			}
 		};

diff --git a/js/iframeResizer.contentWindow.map b/js/iframeResizer.contentWindow.map