Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config and job files for disc C/O paper #3

Merged
merged 14 commits into from
Dec 19, 2023

Conversation

jymah
Copy link
Contributor

@jymah jymah commented Dec 7, 2023

No description provided.

@AaronDavidSchneider
Copy link
Owner

@jymah can you add a description text for the docs?

Alternatively you can change the docs in your fork yourself and implement the instructions for your config files there.

To do so, you just have to edit the files in the doc/source. For example Quick-Start.rst

@jymah
Copy link
Contributor Author

jymah commented Dec 19, 2023

@AaronDavidSchneider yes, I will do so. Umm, so I just modify Quick-Start.rst in my fork and you will be able to see the changes? Or should I submit another PR? Sorry that this is taking longer than expected.

Edit: I changed the Quick-Start.rst file in my fork and deleted the config and job files for the planet simulations (for simplicity; I did not want to explain that we need to change the gas accretion file)

@AaronDavidSchneider
Copy link
Owner

Yes that's exactly what I meant!
Nice. Let me know when you are done and I will merge it 😊

@jymah
Copy link
Contributor Author

jymah commented Dec 19, 2023

I am done with the changes :)

Copy link
Owner

@AaronDavidSchneider AaronDavidSchneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronDavidSchneider AaronDavidSchneider merged commit 8857777 into AaronDavidSchneider:main Dec 19, 2023
2 checks passed
@AaronDavidSchneider
Copy link
Owner

Thanks @jymah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants