Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend fixes #118

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Backend fixes #118

merged 3 commits into from
Nov 8, 2023

Conversation

TheSlimvReal
Copy link
Contributor

@TheSlimvReal TheSlimvReal commented Nov 7, 2023

On the dev server there is currently an issue where the changes are requested continuously.
This is because the last_seq is not returned correctly from the backend due to a special permissions-data setup.

Also we sometimes see error messages on the backend where the rules object fetch times out (AxiosError: maxContentLength size of -1 exceeded.
Normally this is a longpoll and it should be possible to have a open connection for multiple minutes but the axios request times out after one minute. The same happens when using native NodeJS fetch. If the same request is send from the command line using curl, everything works fine (I had a exception after around 9 minutes). I did not find a way to change anything the app. I don't think the servers nginx setup is the issue because the requests work fine without the backend.
I now reduced the timeout for CouchDB to 50s so it does not throw errors anymore.

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks a lot for troubleshooting that and figuring out these fixes!

src/permissions/rules/rules.service.ts Outdated Show resolved Hide resolved
@TheSlimvReal TheSlimvReal merged commit dc5173d into master Nov 8, 2023
5 checks passed
@TheSlimvReal TheSlimvReal deleted the invalid_changes_fix branch November 8, 2023 07:24
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants