Bump JetBrains/qodana-action from 2024.1.5 to 2024.2.6 #2044
1109 new problems found by Qodana Community for JVM
Qodana Community for JVM
1109 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Kotlin sanity |
🔴 Failure | 1 |
Missing KDoc comments for public declarations |
🔶 Warning | 829 |
Hardcoded strings |
🔶 Warning | 60 |
Unstable API Usage |
🔶 Warning | 29 |
Unused symbol |
🔶 Warning | 29 |
Incorrect string capitalization |
🔶 Warning | 3 |
Unused import directive |
🔶 Warning | 3 |
Redundant nullable return type |
🔶 Warning | 3 |
Redundant call of conversion method |
🔶 Warning | 2 |
Local 'var' is never modified and can be declared as 'val' |
🔶 Warning | 1 |
Convert to primary constructor |
🔶 Warning | 1 |
Unresolved reference in KDoc |
🔶 Warning | 1 |
Redundant qualifier name |
🔶 Warning | 1 |
Test-only usage in production code |
🔶 Warning | 1 |
Public API declaration with implicit return type |
◽️ Notice | 43 |
Class member can have 'private' visibility |
◽️ Notice | 29 |
Not-null assertion can be replaced with 'return' |
◽️ Notice | 18 |
Unnecessary type argument |
◽️ Notice | 11 |
Use destructuring declaration |
◽️ Notice | 10 |
Property naming convention |
◽️ Notice | 5 |
Variable declaration could be moved inside 'when' |
◽️ Notice | 4 |
If-Null return/break/... foldable to '?:' |
◽️ Notice | 3 |
Redundant empty primary constructor |
◽️ Notice | 3 |
'associate' can be replaced with 'associateBy' or 'associateWith' |
◽️ Notice | 3 |
Argument could be converted to 'Set' to improve performance |
◽️ Notice | 2 |
Nested lambda has shadowed implicit parameter |
◽️ Notice | 2 |
Object literal can be converted to lambda |
◽️ Notice | 2 |
Call chain on collection type can be simplified |
◽️ Notice | 2 |
Cascade 'if' can be replaced with 'when' |
◽️ Notice | 1 |
Function or property has platform type |
◽️ Notice | 1 |
Null-checks can be replaced with safe-calls |
◽️ Notice | 1 |
Private property naming convention |
◽️ Notice | 1 |
Negated call can be simplified |
◽️ Notice | 1 |
Unnecessary local variable |
◽️ Notice | 1 |
Accessor call that can be replaced with property access syntax |
◽️ Notice | 1 |
Verbose nullability and emptiness check |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
View the detailed Qodana report
To be able to view the detailed Qodana report, you can either:
- Register at Qodana Cloud and configure the action
- Use GitHub Code Scanning with Qodana
- Host Qodana report at GitHub Pages
- Inspect and use
qodana.sarif.json
(see the Qodana SARIF format for details)
To get *.log
files or any other Qodana artifacts, run the action with upload-result
option set to true
,
so that the action will upload the files as the job artifacts:
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: true
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
github-actions / Qodana Community for JVM
Local 'var' is never modified and can be declared as 'val'
Variable is never modified, so it can be declared using 'val'
Check notice on line 186 in src/main/kotlin/fi/aalto/cs/apluscourses/ui/overview/OverviewView.kt
github-actions / Qodana Community for JVM
Cascade 'if' can be replaced with 'when'
Cascade 'if' should be replaced with 'when'
Check notice on line 146 in src/main/kotlin/fi/aalto/cs/apluscourses/model/component/Module.kt
github-actions / Qodana Community for JVM
Argument could be converted to 'Set' to improve performance
The argument can be converted to 'Set' to improve performance
Check notice on line 145 in src/main/kotlin/fi/aalto/cs/apluscourses/model/component/Module.kt
github-actions / Qodana Community for JVM
Argument could be converted to 'Set' to improve performance
The argument can be converted to 'Set' to improve performance
Check warning on line 203 in src/main/kotlin/fi/aalto/cs/apluscourses/model/component/Module.kt
github-actions / Qodana Community for JVM
Convert to primary constructor
Secondary constructor should be converted to a primary one
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
Check notice on line 9 in src/main/kotlin/fi/aalto/cs/apluscourses/model/news/NewsList.kt
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
Check notice on line 238 in src/main/kotlin/fi/aalto/cs/apluscourses/ui/overview/OverviewView.kt
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
Check notice on line 66 in src/main/kotlin/fi/aalto/cs/apluscourses/utils/PluginAutoInstaller.kt
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Use destructuring declaration
Use destructuring declaration
github-actions / Qodana Community for JVM
Incorrect string capitalization
String 'ð¦' is not properly capitalized. It should have title capitalization
github-actions / Qodana Community for JVM
Incorrect string capitalization
String 'ð' is not properly capitalized. It should have title capitalization
Check warning on line 115 in src/main/kotlin/fi/aalto/cs/apluscourses/config/APlusConfigurable.kt
github-actions / Qodana Community for JVM
Incorrect string capitalization
String 'A+ Courses' is not properly capitalized. It should have sentence capitalization
Check notice on line 55 in src/main/kotlin/fi/aalto/cs/apluscourses/model/component/Module.kt
github-actions / Qodana Community for JVM
If-Null return/break/... foldable to '?:'
If-Null return/break/... foldable to '?:'
Check notice on line 134 in src/main/kotlin/fi/aalto/cs/apluscourses/services/ModuleImportExport.kt
github-actions / Qodana Community for JVM
If-Null return/break/... foldable to '?:'
If-Null return/break/... foldable to '?:'
Check notice on line 14 in src/main/kotlin/fi/aalto/cs/apluscourses/utils/parser/S2FeedbackParser.kt
github-actions / Qodana Community for JVM
If-Null return/break/... foldable to '?:'
If-Null return/break/... foldable to '?:'
Check warning on line 55 in src/main/kotlin/fi/aalto/cs/apluscourses/model/component/ScalaSdk.kt
github-actions / Qodana Community for JVM
Hardcoded strings
Hardcoded string literal: "scala3-library"
Check warning on line 81 in build.gradle.kts
github-actions / Qodana Community for JVM
Hardcoded strings
Hardcoded string literal: ""
Check warning on line 336 in src/main/kotlin/fi/aalto/cs/apluscourses/api/APlusApi.kt
github-actions / Qodana Community for JVM
Hardcoded strings
Hardcoded string literal: "submissions"
github-actions / Qodana Community for JVM
Hardcoded strings
Hardcoded string literal: "#\\u200b\\u200c\\u200b\\u200b\\u200b\\u200b\\u200c\\u200c\\u200b\\u200c\\u200b\\u200c\\u200c\\u200b \*-\* coding: u...