Services #1163
Services #1163
Conversation
…dd better error handling for module imports
There was a problem hiding this comment.
Good work!
I would prefer seeing synchronization handled more separately from the business logic (something similar to what is tried to do [here](https://stackoverflow.com/questions/71038075/launch-one-coroutine-at-a-time-kotlin perhaps giving a Mutex object as a parameter for "launchWithMutex" method) but how it's handled here is ok, I think.
| fun importModules() { | ||
| if (!running.compareAndSet(false, true)) { |
There was a problem hiding this comment.
Consider using Mutex.tryLock instead of AtomicBoolean.compareAndSet. While the functional difference (that is, I think, Mutex ensures happens-before relationships between the occasions it's locked) doesn't necessarily matter here, it would make it more clear that this is about synchronizing.
There was a problem hiding this comment.
Will do this in the next update
Don't allow running multiple instances of some services at once and add better error handling for module imports
Fixes #1153 (hopefully)