Skip to content

Commit

Permalink
Fix DG bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
woke02 committed Nov 12, 2024
1 parent ec42d52 commit c254d83
Show file tree
Hide file tree
Showing 7 changed files with 152 additions and 193 deletions.
329 changes: 144 additions & 185 deletions docs/DeveloperGuide.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/diagrams/ArchitectureSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ Participant ":Storage" as storage STORAGE_COLOR
user -[USER_COLOR]> ui : "/delete 1"
activate ui UI_COLOR

ui -[UI_COLOR]> logic : execute("delete 1")
ui -[UI_COLOR]> logic : execute("/delete 1")
activate logic LOGIC_COLOR

logic -[LOGIC_COLOR]> model : deleteInternshipApplication(x)
logic -[LOGIC_COLOR]> model : delete internship application from list
activate model MODEL_COLOR

model -[MODEL_COLOR]-> logic
Expand Down
4 changes: 2 additions & 2 deletions docs/diagrams/ClearSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ activate ClearCommand
ClearCommand --> AddressBookParser :
deactivate ClearCommand

AddressBookParser --> LogicManager : e
AddressBookParser --> LogicManager : c
deactivate AddressBookParser

LogicManager -> ClearCommand : execute(m)
activate ClearCommand

ClearCommand -> Model : clear all internship applications
ClearCommand -> Model : clears the internship application list
activate Model

Model --> ClearCommand
Expand Down
4 changes: 2 additions & 2 deletions docs/diagrams/FilterSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ StatusPredicate --> FilterCommandParser
deactivate StatusPredicate

create FilterCommand
FilterCommandParser -> FilterCommand : s
FilterCommandParser -> FilterCommand :
activate FilterCommand

FilterCommand --> FilterCommandParser : f
FilterCommand --> FilterCommandParser :
deactivate FilterCommand

FilterCommandParser --> AddressBookParser : f
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/FindSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ NameContainsKeywordsPredicate --> FindCommandParser
deactivate NameContainsKeywordsPredicate

create FindCommand
FindCommandParser -> FindCommand : p
FindCommandParser -> FindCommand :
activate FindCommand

FindCommand --> FindCommandParser :
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/ListSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ deactivate AddressBookParser
LogicManager -> ListCommand : execute(m)
activate ListCommand

ListCommand -> Model : updateFilteredList(PREDICATE_SHOW_ALL)
ListCommand -> Model : updates filtered list to show all internship applications
activate Model

Model --> ListCommand
Expand Down
Binary file added docs/images/chart-ui-bug.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit c254d83

Please sign in to comment.