Update parser #87
Merged
Update parser #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estellelim
reviewed
Oct 21, 2024
| public static final Prefix PREFIX_TAG = new Prefix("t/"); // TODO change? | ||
| public static final Prefix PREFIX_SUBJECT = new Prefix("-subject "); | ||
| public static final Prefix PREFIX_FILEPATH = new Prefix("-filepath "); | ||
| public static final Prefix PREFIX_NAME = new Prefix("\\n "); |
There was a problem hiding this comment.
Please remember to enable the disabled tests!
kohkakohla
requested changes
Oct 21, 2024
| argMultimap.verifyNoDuplicatePrefixesFor(PREFIX_NAME, PREFIX_PHONE, PREFIX_EMAIL, PREFIX_ADDRESS, PREFIX_HOURS); | ||
| Name name = ParserUtil.parseName(argMultimap.getValue(PREFIX_NAME).get()); | ||
| Phone phone = ParserUtil.parsePhone(argMultimap.getValue(PREFIX_PHONE).get()); | ||
| Email email = ParserUtil.parseEmail(argMultimap.getValue(PREFIX_EMAIL).get()); | ||
| Hours hours = ParserUtil.parseHours(argMultimap.getValue(PREFIX_HOURS).get()); | ||
| Address address = ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS).get()); | ||
| Set<Tag> tagList = ParserUtil.parseTags(argMultimap.getAllValues(PREFIX_TAG)); | ||
| Set<Subject> subjects = ParserUtil.parseSubjects(argMultimap.getAllValues(PREFIX_SUBJECT)); | ||
|
|
There was a problem hiding this comment.
Nice! Removed dead code. Well done!
| || !argMultimap.getPreamble().isEmpty()) { | ||
| throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, AddTutorCommand.MESSAGE_USAGE)); | ||
| } | ||
|
|
||
| // Hours is optional for adding a tutee and will be set to 0 if unspecified |
There was a problem hiding this comment.
Good comments letting the reader know what the code does. Very readable, very demure!
|
|
||
| #### On macOS: | ||
| ```shell | ||
| Cmd + Space |
There was a problem hiding this comment.
Hey Mingyang, I don't think command + space is the default shortcut for opening the terminal. Maybe you might want to look into this further?
kohkakohla
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88
fixes #72
Changed: