Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addTuteeCommand, Tutor, Tutee tests #69

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

kohkakohla
Copy link

No description provided.

Copy link

@mingyang143 mingyang143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do correct the merge conflicts locally first before we can merge.

Copy link

@Plishh Plishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice amount of test cases

Tutee bob = new TuteeBuilder().withName("Bob").build();
AddTuteeCommand addAliceCommand = new AddTuteeCommand(alice);
AddTuteeCommand addBobCommand = new AddTuteeCommand(bob);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comments to differentiate different cases

}

@Test
public void isSamePerson() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good comments to differentiate different cases

@kohkakohla kohkakohla added this to the v1.4 milestone Oct 21, 2024
Copy link

@mingyang143 mingyang143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do correct the CI checks before merging

@estellelim estellelim merged commit 54263f1 into AY2425S1-CS2103T-F08-1a:master Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants