Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete JsonAdaptedFreeTime #293

Merged

Conversation

owenyeo
Copy link

@owenyeo owenyeo commented Nov 12, 2023

No description provided.

DG does not contain information about the implementation of
EditUser. This makes it hard for future developers to understand
how it works and therefore may not be able to improve on it.

Add description of EditUserCommand
Add Sequence Diagram
Add explanation of implementation.
JsonAdaptedFreeTime is no longer used in v1.4
@owenyeo owenyeo added the type.Task Something that needs to be done, but not a story, bug or an epic (e.g. move code to new folder) label Nov 12, 2023
@owenyeo owenyeo added this to the v1.4 milestone Nov 12, 2023
Copy link

@kristayeo kristayeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kristayeo kristayeo merged commit bf55c2e into AY2324S1-CS2103T-W12-4:master Nov 13, 2023
0 of 3 checks passed
@owenyeo owenyeo deleted the v1.4-deletefreetime-0 branch November 13, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Something that needs to be done, but not a story, bug or an epic (e.g. move code to new folder)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants