Bug fix: Exclusive end time for FreeTime #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schedule sees end time for TimeBlocks as exclusive. If an event is from 1200 - 1230, schedule recognises that the free time before that ends at 1130, not 1200. Let's: - make endTime of freetime to be inclusive - extend the FreeTime and TimeBlock implementation to include accepting 2400 as the endTime. Now the implementation of FreeTime and TimeBlock allows a range of time intervals starting from 0000 and ending at 2400. This allows events to end at the latest possible timing, which is actually 12am the next day.
andrefoo
added
type.Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule sees end time for TimeBlocks as exclusive. If an event is from 1200 - 1230, schedule recognises that the free time before that ends at 1130, not 1200.
Let's:
Now the implementation of FreeTime and TimeBlock allows a range of time intervals starting from 0000 and ending at 2400.
This allows events to end at the latest possible timing, which is actually 12am the next day.
Resolves #231