Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module code made more flexible #258

Conversation

andrefoo
Copy link

@andrefoo andrefoo commented Nov 8, 2023

Valid module codes like "UTC1114" or "CS1101S" throw an error.

Let's change the module code restraints to be more flexible.

Module name now accepts (2-3A)(3-4N)[A]

Valid module codes like "UTC1114" or "CS1101S" throw an error.

Let's change the module code restraints to be more flexible.

Module name now accepts (2-3A)(3-4N)[A]
@andrefoo andrefoo self-assigned this Nov 8, 2023
@andrefoo andrefoo added type.Bug A bug severity.Medium Occasional inconvenience to some users but can continue to use the product labels Nov 8, 2023
@andrefoo andrefoo added this to the v1.4 milestone Nov 8, 2023
Copy link

@kristayeo kristayeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristayeo kristayeo merged commit dddb38d into AY2324S1-CS2103T-W12-4:master Nov 8, 2023
0 of 3 checks passed
@andrefoo andrefoo linked an issue Nov 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium Occasional inconvenience to some users but can continue to use the product type.Bug A bug
Projects
None yet
2 participants