Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lululwtv.md #252

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Conversation

lululwtv
Copy link

@lululwtv lululwtv commented Nov 7, 2023

Updated lululwtv.md to include personal contributions to the TP

Previously, there were bugs with error messages from addevent, rmevent,
addschedule, and rmschedule.

These bugs were mainly due to differences in command output
and User Guide documentation.

There was also an issue where event names automatically change to lower case
even when they were keyed in upper case.

These issues have been fixed and updated accordingly in the User Guide

Checkstyle issues have been fixed

@lululwtv lululwtv added this to the v1.4 milestone Nov 7, 2023
@lululwtv lululwtv added the documentation Improvements or additions to documentation label Nov 7, 2023
Previously, there were bugs with error messages from addevent, rmevent,
addschedule, and rmschedule.

These bugs were mainly due to differences in command output
and User Guide documentation.

There was also an issue where event names automatically change to lower case
even when they were keyed in upper case.

These issues have been fixed and updated accordingly in the User Guide
UG has been updated to inform users that they can click on their
friends to display their timetable
@lululwtv lululwtv added bug Something isn't working priority.High Must do severity.High A flaw that affects most users, causes major problems for them. and removed priority.High Must do labels Nov 7, 2023
Previously, if there was 1 friend with no common free time,
cft command would only display an error saying that user and friend
have no common free times, and not proceed to show the friends that
have common free times.

This issue has been fixed. Expected output should now be:
You and Friend have no common free time!
You and John Doe have common free times at:
...
Copy link

@owenyeo owenyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenyeo owenyeo merged commit 2d21ae1 into AY2324S1-CS2103T-W12-4:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation severity.High A flaw that affects most users, causes major problems for them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants