forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lululwtv.md #252
Merged
Merged
Update lululwtv.md #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were bugs with error messages from addevent, rmevent, addschedule, and rmschedule. These bugs were mainly due to differences in command output and User Guide documentation. There was also an issue where event names automatically change to lower case even when they were keyed in upper case. These issues have been fixed and updated accordingly in the User Guide
lululwtv
added
bug
Something isn't working
priority.High
Must do
severity.High
A flaw that affects most users, causes major problems for them.
and removed
priority.High
Must do
labels
Nov 7, 2023
Previously, if there was 1 friend with no common free time, cft command would only display an error saying that user and friend have no common free times, and not proceed to show the friends that have common free times. This issue has been fixed. Expected output should now be: You and Friend have no common free time! You and John Doe have common free times at: ...
owenyeo
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
severity.High
A flaw that affects most users, causes major problems for them.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated lululwtv.md to include personal contributions to the TP
Previously, there were bugs with error messages from addevent, rmevent,
addschedule, and rmschedule.
These bugs were mainly due to differences in command output
and User Guide documentation.
There was also an issue where event names automatically change to lower case
even when they were keyed in upper case.
These issues have been fixed and updated accordingly in the User Guide
Checkstyle issues have been fixed