Add test to student #160
Merged
Add test to student #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
============================================
+ Coverage 28.25% 30.38% +2.12%
- Complexity 378 425 +47
============================================
Files 123 126 +3
Lines 3221 3229 +8
Branches 367 370 +3
============================================
+ Hits 910 981 +71
+ Misses 2212 2151 -61
+ Partials 99 97 -2
|
siqirua
approved these changes
Nov 11, 2023
| this.sid = sid; | ||
| } | ||
|
|
||
| /** | ||
| * Returns true if a given string is a valid name. | ||
| */ | ||
| public static boolean isValidName(String test) { | ||
| public static boolean isValidSid(String test) { |
There was a problem hiding this comment.
I like how you rename the variable name !
Comment on lines
+26
to
+64
| assertFalse(StudentEmail.isValidEmail("")); // empty string | ||
| assertFalse(StudentEmail.isValidEmail(" ")); // spaces only | ||
|
|
||
| // missing parts | ||
| assertFalse(StudentEmail.isValidEmail("@example.com")); // missing local part | ||
| assertFalse(StudentEmail.isValidEmail("peterjackexample.com")); // missing '@' symbol | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@")); // missing domain name | ||
|
|
||
| // invalid parts | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@-")); // invalid domain name | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@exam_ple.com")); // underscore in domain name | ||
| assertFalse(StudentEmail.isValidEmail("peter [email protected]")); // spaces in local part | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@exam ple.com")); // spaces in domain name | ||
| assertFalse(StudentEmail.isValidEmail(" [email protected]")); // leading space | ||
| assertFalse(StudentEmail.isValidEmail("[email protected] ")); // trailing space | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@@example.com")); // double '@' symbol | ||
| assertFalse(StudentEmail.isValidEmail("peter@[email protected]")); // '@' symbol in local part | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // local part starts with a hyphen | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // local part ends with a hyphen | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // local part has two consecutive periods | ||
| assertFalse(StudentEmail.isValidEmail("peterjack@example@com")); // '@' symbol in domain name | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // domain name starts with a period | ||
| assertFalse(StudentEmail.isValidEmail("[email protected].")); // domain name ends with a period | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // domain name starts with a hyphen | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // domain name ends with a hyphen | ||
| assertFalse(StudentEmail.isValidEmail("[email protected]")); // top level domain has less than two chars | ||
|
|
||
| // valid email | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // underscore in local part | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // period in local part | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // '+' symbol in local part | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // hyphen in local part | ||
| assertTrue(StudentEmail.isValidEmail("a@bc")); // minimal | ||
| assertTrue(StudentEmail.isValidEmail("test@localhost")); // alphabets only | ||
| assertTrue(StudentEmail.isValidEmail("123@145")); // numeric local part and domain name | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // mixture of alphanumeric and special characters | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // long domain name | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // long local part | ||
| assertTrue(StudentEmail.isValidEmail("[email protected]")); // more than one period in domain |
There was a problem hiding this comment.
I like how you design the test cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.