-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UG amendments for 2101 #176
UG amendments for 2101 #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, suggested a few minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, feel free to directly resolve them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage 63.80% 63.80%
Complexity 750 750
=========================================
Files 104 104
Lines 2970 2970
Branches 325 325
=========================================
Hits 1895 1895
Misses 1002 1002
Partials 73 73 ☔ View full report in Codecov by Sentry. |
Co-authored-by: H1410101 <[email protected]>
Co-authored-by: H1410101 <[email protected]>
note: haven't remove reset confirm screenshot yet
also made the one liner explanation for commands that require index input less convoluted