Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UG amendments for 2101 #176

Merged
merged 10 commits into from
Nov 15, 2023

Conversation

butteredyakiimo
Copy link
Collaborator

@butteredyakiimo butteredyakiimo commented Nov 15, 2023

note: haven't remove reset confirm screenshot yet

also made the one liner explanation for commands that require index input less convoluted

Copy link

@nananakx-x nananakx-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, suggested a few minor changes

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
H1410101
H1410101 previously approved these changes Nov 15, 2023
Copy link
Collaborator

@H1410101 H1410101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, feel free to directly resolve them.

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e02785) 63.80% compared to head (dde424f) 63.80%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage     63.80%   63.80%           
  Complexity      750      750           
=========================================
  Files           104      104           
  Lines          2970     2970           
  Branches        325      325           
=========================================
  Hits           1895     1895           
  Misses         1002     1002           
  Partials         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1410101 H1410101 merged commit 26feafa into AY2324S1-CS2103T-T13-4:master Nov 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants