Fix test cases #192
Merged
Fix test cases #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/neyapraveen/tp: (41 commits) Fix checkstyle Remove code Edit to camelCase Edit tests Edit tests Edit tests Add test cases for check Add MarkCommandTest and UnMarkCommandTest files Add unmark command test Fix checkstyle errors for main and test fix syntax error due to resolving merge conflict Update contact us line in UG Update DG image, DG and PPP Update docs/UserGuide.md Update docs/UserGuide.md Update PPP and DG Update use of person to student in UG Edit UG Edit UG Edit UG ...
neyapraveen
commented
Nov 9, 2023
| }); | ||
| } | ||
| } | ||
| //package seedu.address.ui; |
There was a problem hiding this comment.
ignore the commenting out, this might need to be changed because it doesn't consider multiple test cases using fx simultaneously. Need to rerun and test with @wnchan 's edited test cases
There was a problem hiding this comment.
will resolve the merge conflict
There was a problem hiding this comment.
you can merge first then ill work on fixing the help window test cases to run with yours.
|
LGTM |
wnchan
reviewed
Nov 10, 2023
| }); | ||
| } | ||
| } | ||
| //package seedu.address.ui; |
There was a problem hiding this comment.
you can merge first then ill work on fixing the help window test cases to run with yours.
neyapraveen
merged commit 85c8259
into
AY2324S1-CS2103T-F12-2:master
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test cases for new features.