Branch convert to pdf #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
=========================================
Coverage 90.85% 90.85%
Complexity 832 832
=========================================
Files 97 97
Lines 2188 2188
Branches 305 305
=========================================
Hits 1988 1988
Misses 129 129
Partials 71 71 ☔ View full report in Codecov by Sentry. |
samuelim01
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Roughly looks good to me! Just a few comments:
- According to the CS2103T website, the UG and DG should match the pdf. As such, I think this PR should be merged. Visually, I see little issue with merging. Perhaps we can make the changes such as the Table of Contents on a branch for CS2101.
- I personally feel some of the DG diagrams have been shrunk too much and are now too small.
- I removed a irrelevant line from the glossary (Private contact detail). This should be removed from the repo too.
There was a problem hiding this comment.
For the Appendix, the acceptable values for email are split over two pages. Would it be more natural to move the whole section to a new page? The gap would be rather wide though.
Before:
After:
There was a problem hiding this comment.
The above section between 5.5.2. and 5.6 has a Back to top by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's format the documentations better for PDF formats!
Please do not merge this with the master branch, this PR is for the purpose of anyone wanting to make changes to our PDF format