Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG: Fix content page formatting #270

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

tllshan
Copy link

@tllshan tllshan commented Nov 13, 2023

Let's improve the formatting of the DG by:

  • Adding numbering for Appendix D sub-headers
  • Adding Appendix D to the contents page
  • Fixing broken links in the contents page
  • Standardizing placement of line breaks

@tllshan tllshan requested a review from p-xp November 13, 2023 03:29
@tllshan tllshan added the documentation Improvements or additions to documentation label Nov 13, 2023
@tllshan tllshan added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83b6a3f) 89.86% compared to head (22472e5) 89.86%.
Report is 1 commits behind head on master.

❗ Current head 22472e5 differs from pull request most recent head 6b91492. Consider uploading reports for the commit 6b91492 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage     89.86%   89.86%           
  Complexity      797      797           
=========================================
  Files            97       97           
  Lines          2181     2181           
  Branches        294      294           
=========================================
  Hits           1960     1960           
  Misses          162      162           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tllshan tllshan changed the title DG: improve formatting DG: Fix content page formatting Nov 13, 2023
@keaganpzh keaganpzh mentioned this pull request Nov 13, 2023
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@p-xp p-xp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@p-xp p-xp merged commit d37818f into AY2324S1-CS2103T-F11-2:master Nov 13, 2023
@p-xp p-xp added the type.Task Something that needs to be done, but not a story, bug, or an epic. label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants