forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch improve test and code #269
Merged
wasjoe1
merged 7 commits into
AY2324S1-CS2103T-F11-2:master
from
wasjoe1:branch-improve-test-and-code
Nov 13, 2023
Merged
Branch improve test and code #269
wasjoe1
merged 7 commits into
AY2324S1-CS2103T-F11-2:master
from
wasjoe1:branch-improve-test-and-code
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wasjoe1
commented
Nov 12, 2023
•
edited
Loading
edited
- Add assertions into predicate classes, increases defensive programming & use of assertions
- Checked that testcases adhered to heuristics
- Defined better logging statements
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
============================================
- Coverage 89.86% 89.13% -0.74%
- Complexity 797 813 +16
============================================
Files 97 97
Lines 2181 2199 +18
Branches 294 304 +10
============================================
Hits 1960 1960
Misses 162 162
- Partials 59 77 +18
☔ View full report in Codecov by Sentry. |
samuelim01
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not sure what CodeCov has against you 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.