Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch improve test and code #269

Merged

Conversation

wasjoe1
Copy link
Collaborator

@wasjoe1 wasjoe1 commented Nov 12, 2023

  • Add assertions into predicate classes, increases defensive programming & use of assertions
  • Checked that testcases adhered to heuristics
  • Defined better logging statements

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (36a9c1b) 89.86% compared to head (e6265d6) 89.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
- Coverage     89.86%   89.13%   -0.74%     
- Complexity      797      813      +16     
============================================
  Files            97       97              
  Lines          2181     2199      +18     
  Branches        294      304      +10     
============================================
  Hits           1960     1960              
  Misses          162      162              
- Partials         59       77      +18     
Files Coverage Δ
...edlog/address/logic/parser/GuestCommandParser.java 100.00% <100.00%> (ø)
...dlog/address/logic/parser/VendorCommandParser.java 100.00% <100.00%> (ø)
...log/address/logic/commands/GuestFilterCommand.java 90.00% <0.00%> (-10.00%) ⬇️
...og/address/logic/commands/VendorFilterCommand.java 90.00% <0.00%> (-10.00%) ⬇️
.../wedlog/address/model/person/AddressPredicate.java 87.50% <0.00%> (-12.50%) ⬇️
...va/wedlog/address/model/person/EmailPredicate.java 87.50% <0.00%> (-12.50%) ⬇️
...edlog/address/model/person/GuestRsvpPredicate.java 86.66% <0.00%> (-13.34%) ⬇️
...dlog/address/model/person/GuestTablePredicate.java 87.50% <0.00%> (-12.50%) ⬇️
...ava/wedlog/address/model/person/NamePredicate.java 86.66% <0.00%> (-13.34%) ⬇️
...va/wedlog/address/model/person/PhonePredicate.java 87.50% <0.00%> (-12.50%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure what CodeCov has against you 😭

@wasjoe1 wasjoe1 merged commit 8166296 into AY2324S1-CS2103T-F11-2:master Nov 13, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants