-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UG: Improve from PED #246
Update UG: Improve from PED #246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=========================================
Coverage 90.22% 90.22%
Complexity 830 830
=========================================
Files 100 100
Lines 2260 2260
Branches 305 305
=========================================
Hits 2039 2039
Misses 161 161
Partials 60 60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work :) Just a few nits!
docs/UserGuide.md
Outdated
@@ -64,6 +64,8 @@ WedLog is a desktop app for wedding planning, optimized for use via a Command Li | |||
|
|||
**Notes about the command format:** <br /> | |||
|
|||
* Words are defined to be any letters, numbers or special characters of length 1 or more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on #214, I believe this still means that users who look the section on Address without seeing this small note will still perceive the single digit integer to be not very meaningful. Is it possible to just specify the acceptable values for Address directly as "any non blank values", or something along those lines? We can still keep this definition here for the purposes of the "alphanumeric words" of names, etc.
Oh by the way, if you want your PR to automatically close the issues your mentioned, I think you left out the closing keywords |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
Let's make improvements in our UG to tackle bugs found during PED.
resolves #214
resolves #209
resolves #192