Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PPP (Xinping) #240

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Update PPP (Xinping) #240

merged 2 commits into from
Nov 8, 2023

Conversation

p-xp
Copy link

@p-xp p-xp commented Nov 8, 2023 •
edited
Loading

Resolves #230

@p-xp p-xp requested a review from wasjoe1 November 8, 2023 03:26
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bff3d2) 90.13% compared to head (56fddc2) 90.13%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #240   +/-   ##
=========================================
  Coverage     90.13%   90.13%           
  Complexity      834      834           
=========================================
  Files           104      104           
  Lines          2280     2280           
  Branches        305      305           
=========================================
  Hits           2055     2055           
  Misses          164      164           
  Partials         61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tllshan tllshan linked an issue Nov 8, 2023 that may be closed by this pull request
Update PPP: Xin Ping #230
Closed
@p-xp p-xp changed the title Update PPP Update PPP (Xinping) Nov 8, 2023
wasjoe1
wasjoe1 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@wasjoe1 wasjoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a very very minor nit

docs/team/p-xp.md Outdated Show resolved Hide resolved
@wasjoe1 wasjoe1 merged commit ad02b4c into AY2324S1-CS2103T-F11-2:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasjoe1 wasjoe1 wasjoe1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PPP: Xin Ping
2 participants
@p-xp @wasjoe1