Remove edit command #236
Merged
Remove edit command #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's update the VendorCommandParserTest edit test to use VendorUtil#getEditVendorDescriptorDetails
Let's update the GuestCommandParserTest edit test to use GuestUtil#getEditGuestDescriptorDetails
The `edit` command is deprecated and should not be kept in the code base. Let's, * Remove any EditCommand related code * Remove TracingCode.md, which traces through the edit command
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
============================================
- Coverage 90.30% 90.13% -0.18%
+ Complexity 860 834 -26
============================================
Files 106 104 -2
Lines 2393 2280 -113
Branches 326 305 -21
============================================
- Hits 2161 2055 -106
Misses 164 164
+ Partials 68 61 -7
☔ View full report in Codecov by Sentry. |
According to the [forum](nus-cs2103-AY2324S1/forum#316), the tutorials do not need to be updated or removed. Let's add the TracingCode tutorial back to the docs.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
keaganpzh
reviewed
Nov 7, 2023
src/test/java/wedlog/address/logic/parser/AddressBookParserTest.java
Outdated
Show resolved
Hide resolved
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
editcommand is deprecated and should not be kept in the code base. Fixes #211.Let's,