Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update PPP for Shannon #235

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

tllshan
Copy link

@tllshan tllshan commented Nov 7, 2023

Add details of Shannon's contributions to project portfolio page for Shannon.

Addresses #232.

@tllshan tllshan added the documentation Improvements or additions to documentation label Nov 7, 2023
@tllshan tllshan added this to the v1.4 milestone Nov 7, 2023
@tllshan tllshan requested a review from p-xp November 7, 2023 06:09
@tllshan tllshan linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bff3d2) 90.13% compared to head (feb788b) 90.13%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     90.13%   90.13%           
  Complexity      834      834           
=========================================
  Files           104      104           
  Lines          2280     2280           
  Branches        305      305           
=========================================
  Hits           2055     2055           
  Misses          164      164           
  Partials         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@p-xp p-xp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion on another thing you contributed to the team :D

docs/team/tllshan.md Show resolved Hide resolved
@tllshan tllshan merged commit f31bca7 into AY2324S1-CS2103T-F11-2:master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PPP: Shannon
2 participants