Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with validating booking period and update user guide again #259

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

AnnabelTing
Copy link

Close #220

Booking period did not validate input properly leading to date time error.

The error message shown to users were inconsistent with the user guide.

Let's update the user guide and validate booking period properly.
@AnnabelTing AnnabelTing added this to the v1.4 milestone Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #259 (908e0d1) into master (30efcdf) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
+ Coverage     70.76%   70.82%   +0.05%     
  Complexity      565      565              
============================================
  Files            94       94              
  Lines          1878     1878              
  Branches        211      210       -1     
============================================
+ Hits           1329     1330       +1     
  Misses          488      488              
+ Partials         61       60       -1     
Files Coverage Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 94.00% <100.00%> (ø)
...rc/main/java/seedu/address/model/booking/Room.java 94.11% <ø> (ø)
...rc/main/java/seedu/address/model/person/Email.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/person/Phone.java 100.00% <ø> (ø)
...ava/seedu/address/model/booking/BookingPeriod.java 86.30% <33.33%> (+1.36%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Previous images were outdated as email format has since changed.

Let's keep the user guide updated
@RB9823
Copy link

RB9823 commented Nov 11, 2023

LGTM

@RB9823 RB9823 merged commit 17a9a96 into AY2324S1-CS2103T-F10-1:master Nov 11, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester B] Confusing response to invalid inputs
2 participants