Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find example bug #220

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jamz903
Copy link

@jamz903 jamz903 commented Nov 13, 2023

before fix:
image

after fix:
image

Reason it is a bug & needs to be fixed:

  • all other commands only display 1 command word, using getMainCommandWord(), so this difference makes the messages inconsistent.
  • the example command should allow users to directly copy & paste and for it to work without issues, however without this fix it will be flagged out as incorrect formatting (which it is, since it has multiple command keywords), making the example inaccurate.

I will update this after I receive a reply from Prof in the forum to double check! Link to it is here

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27aa73c) 93.94% compared to head (ea4469d) 93.87%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
- Coverage     93.94%   93.87%   -0.07%     
  Complexity      957      957              
============================================
  Files           103      103              
  Lines          2690     2692       +2     
  Branches        240      241       +1     
============================================
  Hits           2527     2527              
  Misses          116      116              
- Partials         47       49       +2     
Files Coverage Δ
...c/main/java/unicash/commons/enums/CommandType.java 98.20% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamz903 jamz903 added this to the v1.4 milestone Nov 13, 2023
@jamz903 jamz903 added the type.Bug A bug label Nov 13, 2023
@jamz903
Copy link
Author

jamz903 commented Nov 14, 2023

Propose to merge even with codecov proj failing, as the affected lines are not directly impacted, according to the codecov report

Copy link

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamz903 jamz903 merged commit bad9f9d into AY2324S1-CS2103-T16-3:master Nov 14, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants