Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving unit testing #196

Merged
merged 12 commits into from
Nov 10, 2023

Conversation

woojiahao
Copy link

@woojiahao woojiahao commented Nov 10, 2023

  • AddTransactionCommand
  • AddTransactionCommandParser
  • UniqueCategoryList
  • TransactionList
  • ParserUtil
  • Prefix
  • SampleDataUtil
  • BudgetNotFoundException

@woojiahao woojiahao marked this pull request as draft November 10, 2023 08:29
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a918c57) 91.97% compared to head (7b0b596) 92.09%.
Report is 13 commits behind head on master.

❗ Current head 7b0b596 differs from pull request most recent head d0c100d. Consider uploading reports for the commit d0c100d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
+ Coverage     91.97%   92.09%   +0.11%     
- Complexity      939      942       +3     
============================================
  Files           104      104              
  Lines          2693     2693              
  Branches        236      236              
============================================
+ Hits           2477     2480       +3     
  Misses          161      161              
+ Partials         55       52       -3     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woojiahao woojiahao marked this pull request as ready for review November 10, 2023 08:53
Copy link

@lipwei1808 lipwei1808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the comprehensive tests!

@woojiahao woojiahao merged commit 7e69600 into AY2324S1-CS2103-T16-3:master Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants