Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give code reuse credits #306

Merged

Conversation

HmuuMyatMoe
Copy link

No description provided.

@HmuuMyatMoe HmuuMyatMoe added this to the v1.4 milestone Apr 10, 2023
@HmuuMyatMoe HmuuMyatMoe requested a review from a team April 10, 2023 14:31
Copy link

@LiuMC-SG LiuMC-SG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (798a8a8) 71.06% compared to head (2303701) 71.06%.

❗ Current head 2303701 differs from pull request most recent head 16537a9. Consider uploading reports for the commit 16537a9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #306   +/-   ##
=========================================
  Coverage     71.06%   71.06%           
  Complexity     1010     1010           
=========================================
  Files           170      170           
  Lines          3107     3107           
  Branches        390      390           
=========================================
  Hits           2208     2208           
  Misses          827      827           
  Partials         72       72           
Impacted Files Coverage Δ
...ain/java/trackr/logic/commands/AddItemCommand.java 92.30% <ø> (ø)
...trackr/logic/commands/order/SortOrdersCommand.java 0.00% <ø> (ø)
...ava/trackr/logic/commands/task/AddTaskCommand.java 100.00% <ø> (ø)
...va/trackr/logic/commands/task/EditTaskCommand.java 84.61% <ø> (ø)
...va/trackr/logic/commands/task/ListTaskCommand.java 100.00% <ø> (ø)
...a/trackr/logic/commands/task/SortTasksCommand.java 88.88% <ø> (ø)
...ain/java/trackr/logic/parser/ArgumentMultimap.java 100.00% <ø> (ø)
src/main/java/trackr/logic/parser/ParserUtil.java 86.44% <ø> (ø)
...rc/main/java/trackr/logic/parser/TrackrParser.java 55.10% <ø> (ø)
...va/trackr/logic/parser/UploadCsvCommandParser.java 1.58% <ø> (ø)
... and 18 more

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HmuuMyatMoe HmuuMyatMoe merged commit bf0b6d3 into AY2223S2-CS2103T-W15-2:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants