Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prefix table, add title to user guide #307

Merged
merged 25 commits into from
Apr 10, 2023

Conversation

jweeyh
Copy link

@jweeyh jweeyh commented Apr 10, 2023

No description provided.

Copy link

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	docs/UserGuide.md
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #307 (76ba46a) into master (510f87c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #307   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity      857      857           
=========================================
  Files           127      127           
  Lines          2485     2485           
  Branches        325      325           
=========================================
  Hits           1917     1917           
  Misses          477      477           
  Partials         91       91           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

---

# **1. Introduction**

# 1. Introduction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it bold for consistency

docs/UserGuide.md Outdated Show resolved Hide resolved
@@ -303,7 +322,7 @@ Examples:



### 4.1.5. Find employee by ID: `feid`
### 4.1.5. Find employees by ID: `feid`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "employee" because only one employee has the ID


---
* Table of Contents
{:toc}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove indent

|-------------------------|----------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **ID** | id/ | {::nomarkdown} ID is the unique identifier for an employee. Leading zeroes are ignored. <br/> **Note: This flag is only used when adding an employee into the app**. <br/> It has the following constraints: <br/> <ul> <li> Must be a positive integer <ol> <li> 0 is often reserved for administrative use </li> <li> negative numbers are not conventionally used </li> </ol> </li> <li> Cannot be empty </li> </ul> <br/> Valid Examples: <ul> <li>1</li> <li>100</li> </ul> Invalid Examples: <ul> <li>Bob</li> <li>0</li> <li>-1</li> </ul> {:/} |
| **ID** | id/ | {::nomarkdown} ID is the unique identifier for an employee. Leading zeroes are ignored. <br/> **Note**: This flag is only used when adding an employee into the app. <br/> It has the following constraints: <br/> <ul> <li> Must be a positive integer <ol> <li> 0 is often reserved for administrative use </li> <li> negative numbers are not conventionally used </li> </ol> </li> <li> Cannot be empty </li> </ul> <br/> Valid Examples: <ul> <li>1</li> <li>100</li> <li>001000</li> </ul> Invalid Examples: <ul> <li>Bob</li> <li>0</li> <li>-1</li> </ul> |
| **EMPLOYEE_ID** | eid/ | Similar to ID, The EMPLOYEE_ID represents the ID of an employee. <br/> It is used for any commands that require referencing an employee. <br/> It follows the same constraints as ID. {:/} |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

# Conflicts:
#	docs/UserGuide.md
@kennethk-1201 kennethk-1201 merged commit e8d8d22 into AY2223S2-CS2103T-T17-2:master Apr 10, 2023
@jweeyh jweeyh added this to the v1.4 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants